fix(git-node): fix handling of existing trailers#1056
Open
aduh95 wants to merge 1 commit intonodejs:mainfrom
Open
fix(git-node): fix handling of existing trailers#1056aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95 wants to merge 1 commit intonodejs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1056 +/- ##
=======================================
Coverage 80.56% 80.56%
=======================================
Files 39 39
Lines 4846 4846
=======================================
Hits 3904 3904
Misses 942 942 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In nodejs/node#62401, the author has added manually the
PR-URLfor some reason, which gets filtered out since #1036. However, we had another piece of code that skips adding metadata that was on the original commit message – which was filtered out.This PR is taking a different approach of removing all the original trailers, adding back the one we won't add ourselves, and finally adding all the "automated ones".